Improve automatic generation#32
Merged
Merged
Conversation
pcothenet
commented
Aug 31, 2021
Comment on lines
+19
to
+21
| from patch_api.models.create_bitcoin_estimate_request import ( | ||
| CreateBitcoinEstimateRequest, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Those models were previously ignored by our codegen.
Proposing to stay as close as possible from the standard output of https://github.com/OpenAPITools/openapi-generator and stop ignoring them.
AFAIK, this has no impact.
kleinjm
approved these changes
Aug 31, 2021
kleinjm
left a comment
kleinjm
left a comment
Contributor
There was a problem hiding this comment.
not a blocker but I'd suggest a patch version bump on this one as well for both parity and because it is a change that could break. Now that we have the user agent, we can monitor for issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
SDK Release Checklist